-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
/benchmark runtime pallet pallet_contracts |
Benchmark Runtime Pallet for branch "at-instantiate-weight" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
4126bc8
to
3b6e15b
Compare
/benchmark runtime pallet pallet_contracts |
Benchmark Runtime Pallet for branch "at-instantiate-weight" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
ERROR: Unable to commit file ./frame/contracts/src/weights.rs |
3b6e15b
to
9657fa0
Compare
/benchmark runtime pallet pallet_contracts |
Benchmark Runtime Pallet for branch "at-instantiate-weight" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
bd1320e
to
14e6a6e
Compare
/benchmark runtime pallet pallet_contracts |
Benchmark Runtime Pallet for branch "at-instantiate-weight" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
b3efcad
to
5f00fb7
Compare
bot merge force |
Error: Required status check "continuous-integration/gitlab-check-dependent-cumulus" is failing. |
It turns out that #10146 wasn't fixing the thing as I intended because I had the wrong assumptions. The weight for
instantiate_with_code
is actually correct to be that big because it includes the weight for loading the code into the sandbox whichcall
forgoes.👮♀️👮♀️👮♀️ So the actual bug is that the weight of
instantiate
andcall
is too low 👮♀️👮♀️👮♀️After fixing this the weight of
instantiate_with_code
shouldn't look so high anymore in comparison because it saves the weight for loading the code into the sandbox which is now charged dynamically from the weight meter when loading an existing code from storage (which does not happen in case ofinstantiate_with_code
).